some tests and major cleanup

pkg/store/boltstore.go

@@ -8,7 +8,10 @@ import (
 	"io"
 )
 
-const defaultBoltBucket = "default"
+const (
+	defaultBoltBucket = "default"
+	fileMode          = 0640
+)
 
 type BoltStore struct {
 	Marshaler
@@ -19,7 +22,7 @@ func NewBoltStore(file string, m Marshaler) (bs *BoltStore, err error) {
 	if m == nil {
 		m = NewGOB()
 	}
-	db, err := bolt.Open(file, 0640, nil)
+	db, err := bolt.Open(file, fileMode, nil)
 	if err != nil {
 		return
 	}

pkg/store/boltstore_test.go

@@ -0,0 +1,99 @@
+// Copyright (C) 2018 Marius Schellenberger
+
+package store
+
+import (
+	"bytes"
+	"errors"
+	"io/ioutil"
+	"os"
+	"path/filepath"
+	"testing"
+)
+
+type testData struct {
+	Data string
+}
+
+func TestBoltStore(t *testing.T) {
+	data := []testData{
+		{"123"},
+		{"hello"},
+	}
+	dir, err := ioutil.TempDir("", "")
+	if err != nil {
+		t.Fatal(err)
+	}
+	defer os.RemoveAll(dir)
+	bs, err := NewBoltStore(filepath.Join(dir, "bolt.db"), nil)
+	if err != nil {
+		t.Fatal(err)
+	}
+
+	err = bs.Set("key0", data[0])
+	if err != nil {
+		t.Fatal(err)
+	}
+	err = bs.Set("key1", data[1])
+	if err != nil {
+		t.Fatal(err)
+	}
+
+	t.Run("GetKey0", func(t *testing.T) {
+		var d testData
+		err := bs.Get("key0", &d)
+		if err != nil {
+			t.Fatal(err)
+		}
+		if d != data[0] {
+			t.Error("d is not data[0]")
+		}
+	})
+	t.Run("ForEach", func(t *testing.T) {
+		err := bs.ForEach(func(k string, v []byte) error {
+			if k == "key0" || k == "key1" {
+				return nil
+			}
+			return errors.New("key0 or key1 not found")
+		})
+		if err != nil {
+			t.Fatal(err)
+		}
+	})
+	t.Run("DumpRestore", func(t *testing.T) {
+		buf := new(bytes.Buffer)
+		err := bs.Dump(buf)
+		if err != nil {
+			t.Fatal(err)
+		}
+		if buf.Len() == 0 {
+			t.Error("no dump written")
+		}
+		err = bs.Restore(buf)
+		if err != nil {
+			t.Fatal(err)
+		}
+	})
+	t.Run("DeleteKey1", func(t *testing.T) {
+		err := bs.Delete("key1")
+		if err != nil {
+			t.Fatal(err)
+		}
+	})
+	t.Run("GetKey1", func(t *testing.T) {
+		var d testData
+		err := bs.Get("key1", &d)
+		if err == nil {
+			t.Error("key1 should be deleted")
+		}
+		if d == data[1] {
+			t.Error("d is not data[1]")
+		}
+	})
+	t.Run("Close", func(t *testing.T) {
+		err := bs.Close()
+		if err != nil {
+			t.Fatal(err)
+		}
+	})
+}

pkg/store/store.go

@@ -2,16 +2,12 @@
 
 package store
 
-import "fmt"
-
-func storeErr(i interface{}) error {
-	return fmt.Errorf("store: %s", i)
-}
+import "errors"
 
 var (
-	ErrKeyNotFound = storeErr("key not found")
-	ErrWriterIsNil = storeErr("writer is nil")
-	ErrReaderIsNil = storeErr("reader is nil")
+	ErrKeyNotFound = errors.New("store: key not found")
+	ErrWriterIsNil = errors.New("store: writer is nil")
+	ErrReaderIsNil = errors.New("store: reader is nil")
 )
 
 type Store interface {