ston1th/node_exporter
0
0
Fork 0
Code Issues Releases Activity

Use the offset calculation that includes round trip time in the ntp collector

Browse source 
Previously the raw time difference was used which includes the network trip time
between the node and the ntp server. This makes setting alerts off the value
troublesome as it depends on the latency as well as the clock offset.
This commit is contained in:
Chris Batey 2016-06-01 08:56:20 +01:00
commit 387c64424b
5 changed files with 140 additions and 40 deletions
Download patch file Download diff file Expand all files Collapse all files

9
collector/ntp.go
View file

@ -18,7 +18,6 @@ package collector
import (
"flag"
"fmt"
"time"
"github.com/beevik/ntp"
"github.com/prometheus/client_golang/prometheus"
@ -58,13 +57,13 @@ func NewNtpCollector() (Collector, error) {
}
func (c *ntpCollector) Update(ch chan<- prometheus.Metric) (err error) {
t, err := ntp.TimeV(*ntpServer, byte(*ntpProtocolVersion))
resp, err := ntp.Query(*ntpServer, *ntpProtocolVersion)
if err != nil {
return fmt.Errorf("couldn't get NTP drift: %s", err)
}
drift := t.Sub(time.Now())
log.Debugf("Set ntp_drift_seconds: %f", drift.Seconds())
c.drift.Set(drift.Seconds())
driftSeconds := resp.ClockOffset.Seconds()
log.Debugf("Set ntp_drift_seconds: %f", driftSeconds)
c.drift.Set(driftSeconds)
c.drift.Collect(ch)
return err
}