ston1th/node_exporter
0
0
Fork 0
Code Issues Releases Activity

Remove unnecessarily named return variables

Browse source 
Named return variables should only be used to describe the returned type
further, e.g. `err error` doesn't add any new information and is just
stutter.
This commit is contained in:
Tobias Schmidt 2017-02-28 14:47:20 -04:00
commit 922e74d58f
32 changed files with 54 additions and 56 deletions
Download patch file Download diff file Expand all files Collapse all files

18
collector/mdadm_linux.go
View file

@ -274,17 +274,15 @@ var (
)
)
func (c *mdadmCollector) Update(ch chan<- prometheus.Metric) (err error) {
func (c *mdadmCollector) Update(ch chan<- prometheus.Metric) error {
statusfile := procFilePath("mdstat")
// take care we don't crash on non-existent statusfiles
_, err = os.Stat(statusfile)
if os.IsNotExist(err) {
// no such file or directory, nothing to do, just return
log.Debugf("Not collecting mdstat, file does not exist: %s", statusfile)
return nil
}
if err != nil { // now things get weird, better to return
if _, err := os.Stat(statusfile); err != nil {
// Take care we don't crash on non-existent statusfiles.
if os.IsNotExist(err) {
// no such file or directory, nothing to do, just return
log.Debugf("Not collecting mdstat, file does not exist: %s", statusfile)
return nil
}
return err
}