ston1th/node_exporter
0
0
Fork 0
Code Issues Releases Activity

Remove unnecessarily named return variables

Browse source 
Named return variables should only be used to describe the returned type
further, e.g. `err error` doesn't add any new information and is just
stutter.
This commit is contained in:
Tobias Schmidt 2017-02-28 14:47:20 -04:00
commit 922e74d58f
32 changed files with 54 additions and 56 deletions
Download patch file Download diff file Expand all files Collapse all files

11
collector/megacli.go
View file

@ -71,16 +71,17 @@ func NewMegaCliCollector() (Collector, error) {
}, nil
}
func (c *megaCliCollector) Update(ch chan<- prometheus.Metric) (err error) {
err = c.updateAdapter()
if err != nil {
func (c *megaCliCollector) Update(ch chan<- prometheus.Metric) error {
if err := c.updateAdapter(); err != nil {
return err
}
if err := c.updateDisks(); err != nil {
return err
}
err = c.updateDisks()
c.driveTemperature.Collect(ch)
c.driveCounters.Collect(ch)
c.drivePresence.Collect(ch)
return err
return nil
}
func parseMegaCliDisks(r io.Reader) (map[int]map[int]map[string]string, error) {