ston1th/node_exporter
0
0
Fork 0
Code Issues Releases Activity

Early init of procfs (#1315)

Browse source 
Minor change to match naming convention in other collectors.

Initialize the proc or sys FS instance once while initializing
each collector instead of re-creating for each metric update.

Signed-off-by: Paul Gier <pgier@redhat.com>
This commit is contained in:
Paul Gier 2019-04-10 11:16:12 -05:00 • committed by Ben Kochie
commit b1298677aa
8 changed files with 63 additions and 47 deletions
Download patch file Download diff file Expand all files Collapse all files

14
collector/buddyinfo.go
View file

@ -30,6 +30,7 @@ const (
)
type buddyinfoCollector struct {
fs procfs.FS
desc *prometheus.Desc
}
@ -44,18 +45,17 @@ func NewBuddyinfoCollector() (Collector, error) {
"Count of free blocks according to size.",
[]string{"node", "zone", "size"}, nil,
)
return &buddyinfoCollector{desc}, nil
fs, err := procfs.NewFS(*procPath)
if err != nil {
return nil, fmt.Errorf("failed to open procfs: %v", err)
}
return &buddyinfoCollector{fs, desc}, nil
}
// Update calls (*buddyinfoCollector).getBuddyInfo to get the platform specific
// buddyinfo metrics.
func (c *buddyinfoCollector) Update(ch chan<- prometheus.Metric) error {
fs, err := procfs.NewFS(*procPath)
if err != nil {
return fmt.Errorf("failed to open procfs: %v", err)
}
buddyInfo, err := fs.NewBuddyInfo()
buddyInfo, err := c.fs.NewBuddyInfo()
if err != nil {
return fmt.Errorf("couldn't get buddyinfo: %s", err)
}