From 068b1d8a243bb0d357baa74d395e6175148fa375 Mon Sep 17 00:00:00 2001 From: Antoine Jacoutot Date: Wed, 28 May 2014 10:27:22 +0200 Subject: [PATCH] Use a directory with mktemp(1) instead of files. This allows us to rm the directory instead of having to rm with a wildcard. idea from otto@openbsd --- openup | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/openup b/openup index d22e6d4..b1ff00e 100755 --- a/openup +++ b/openup @@ -90,14 +90,15 @@ if [ -n "${_badrel}" ]; then fi _ARCH=$(arch -s) -_TMPDIR="${TMPDIR:=/tmp}" -_TMPKEY=$(mktemp -p ${_TMPDIR} .openup-pkg_key.XXXXXXXXXX) || exit 1 -_TMPSPLITCERT=$(mktemp -p ${_TMPDIR} .openup-split_cert.XXXXXXXXXX) || exit 1 -_TMPVUXML=$(mktemp -p ${_TMPDIR} .openup-vuxml.XXXXXXXXXX) || exit 1 +_TMP="${TMPDIR:=/tmp}" +_TMPDIR=$(mktemp -dp ${_TMP} .openup-XXXXXXXXXX) || exit 1 +_TMPKEY="${_TMPDIR}/key" +_TMPSPLITCERT="${_TMPDIR}/cert" +_TMPVUXML="${_TMPDIR}/vuxml" export PKG_PATH=${PKG_PATH_UPDATE}:${PKG_PATH_MAIN} -trap "rm -f ${_TMPDIR}/.openup-*" 1 2 3 13 15 +trap "rm -rf ${_TMPDIR}" 1 2 3 13 15 pr_bigarrow() { if [ -z "${checkmode}" ]; then @@ -328,4 +329,4 @@ fi do_i_need_to_reboot -rm -f ${_TMPDIR}/.openup-* +rm -rf ${_TMPDIR}