more cleanup

main.go

@@ -44,15 +44,7 @@ func main() {
 				http.Redirect(w, r, "/", http.StatusMovedPermanently)
 				return
 			}
-			c := &http.Cookie{
+			setCookie(w, loc)
-				Name:     "loc",
-				Path:     "/",
-				Value:    loc,
-				Secure:   true,
-				HttpOnly: true,
-				SameSite: http.SameSiteStrictMode,
-			}
-			http.SetCookie(w, c)
 			http.Redirect(w, r, "/", http.StatusMovedPermanently)
 			return
 		}
@@ -61,55 +53,26 @@ func main() {
 	http.HandleFunc("/", func(w http.ResponseWriter, r *http.Request) {
 		cc := r.CookiesNamed("loc")
 		var c *http.Cookie
-		if len(cc) == 0 {
+		if len(cc) > 0 {
-			c = &http.Cookie{
-				Name:     "loc",
-				Path:     "/",
-				Value:    DefaultCity,
-				Secure:   true,
-				HttpOnly: true,
-				SameSite: http.SameSiteStrictMode,
-			}
-			http.SetCookie(w, c)
-		} else {
 			c = cc[0]
+		} else {
+			c = setCookie(w, DefaultCity)
 		}
 		num, ok := locFromString(c.Value)
 		if !ok {
-			fmt.Fprintf(w, indexPage,
+			writeError(w, "Error", "Error")
-				"000000",
-				"Error",
-				"Error",
-				time.Now().Format(time.RFC1123),
-				"Error",
-				version,
-			)
 			return
 		}
 		img, mod, err := ic.getImage(num)
 		mod = mod.Local()
 		location := cityList[num]
 		if err != nil {
-			fmt.Fprintf(w, indexPage,
+			writeError(w, mod.Format(time.RFC1123), location)
-				"000000",
-				"Error",
-				mod.Format(time.RFC1123),
-				time.Now().Format(time.RFC1123),
-				location,
-				version,
-			)
 			return
 		}
 		vals := getUV(img)
 		if len(vals) == 0 {
-			fmt.Fprintf(w, indexPage,
+			writeError(w, mod.Format(time.RFC1123), location)
-				"000000",
-				"Error",
-				mod.Format(time.RFC1123),
-				time.Now().Format(time.RFC1123),
-				location,
-				version,
-			)
 			return
 		}
 		last := vals[len(vals)-1]
@@ -128,6 +91,30 @@ func main() {
 	}
 }
 
+func setCookie(w http.ResponseWriter, loc string) *http.Cookie {
+	c := &http.Cookie{
+		Name:     "loc",
+		Path:     "/",
+		Value:    loc,
+		Secure:   true,
+		HttpOnly: true,
+		SameSite: http.SameSiteStrictMode,
+	}
+	http.SetCookie(w, c)
+	return c
+}
+
+func writeError(w http.ResponseWriter, mod, location string) {
+	fmt.Fprintf(w, indexPage,
+		"000000",
+		"Error",
+		mod,
+		time.Now().Format(time.RFC1123),
+		location,
+		version,
+	)
+}
+
 func fatal(err error) {
 	if err != nil {
 		fmt.Println(err)